(Refactor) Add basic test #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to make tests work. Otherwise, there is an issue with a dependency requiring a '.node' file, that is not supported in the version of jest-resolve that react-scripts@1.0.10 uses.
|
Looks good to me. |
mark-antony1
approved these changes
Nov 8, 2017
vbaranov
approved these changes
Nov 9, 2017
This was referenced Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to add a test in another branch I'm working on and I found out that tests that depend (directly or indirectly) on
web3would fail. This happens because the version ofreact-scriptswe are using has an issue with files with.nodeextension (web3depends onscrypt, that has a dependency of this type). See the last bug fix here for more information.I added some basic tests to demonstrate the problem. If you checkout this branch and run
npm run test:dapp, you'll see the problem. Upgrading the dependencies (npm install) should fix that issue.The last version of
react-scriptsis1.0.17and there seems to be no breaking changes, but I just upgraded to1.0.11to avoid unnecessary risks.