Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use functools.wraps in decorator #5

Merged
merged 1 commit into from
Oct 18, 2014

Conversation

toddsifleet
Copy link
Contributor

  • This will ensure that the func_name and doc_strings are correct across py versions
  • Fixes issue Python 3 support #2

* This will ensure that the func_name/doc strings is correct across py versions
* Fixes issue pnpnpn#2
@pnpnpn
Copy link
Owner

pnpnpn commented Oct 16, 2014

Did you test this on both python27 and python3?

@toddsifleet
Copy link
Contributor Author

I did, you may want to checkout travis ci, it could automatically run the tests across multiple python version for every pull request.

Test Output:

tws-test:~/timeout-decorator# nosetests tests
.....
----------------------------------------------------------------------
Ran 5 tests in 3.013s

OK
tws-test:~/timeout-decorator# nosetests-2.7 tests
.....
----------------------------------------------------------------------
Ran 5 tests in 3.009s

OK
tws-test:~/timeout-decorator# nosetests-3.4 tests
.....
----------------------------------------------------------------------
Ran 5 tests in 3.018s

OK

pnpnpn added a commit that referenced this pull request Oct 18, 2014
Use functools.wraps in decorator
@pnpnpn pnpnpn merged commit 7f86ec1 into pnpnpn:master Oct 18, 2014
@toddsifleet toddsifleet mentioned this pull request Oct 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants