Update to node 24 - breaking pipelines with old GitHub runners

[kvnschlndt]

@zkochan The update from node 20 to 24 broke our pipelines :)
Maybe it makes sense to release this update with a new v5 version?

[R-Bower]

I am seeing the same. The best practice here is to use v5 since this is a breaking change.

We'd also need the v4 ref to point to a new v4.4.1 that reverts the breaking change.

[kvnschlndt]

@zkochan i see a few thumbs up, any news here?

[zkochan]

Your image is not loading. I thought the update is only affecting the node.js that is running pnpm cli. Or is it also used when running postinstall scripts? Is the postinstall script of a dependency breaking?

[zkochan]

ok, I see the image now. Why is this error happening not on all jobs?

[Codejune]

@zkochan
Recently, i’m experiencing the same issue.

In our CI environment, we are using a self-hosted runner with the following setup:

jobs:
  ...
  run-tests-and-scan:
    runs-on: [ self-hosted, Linux, X64, pull ]

    steps:
      - name: Checkout codes
        uses: actions/checkout@v4

      - name: Set up pnpm
        uses: pnpm/action-setup@v4
        with:
          version: 8.1.0

      - name: Set up node
        uses: actions/setup-node@v3
        with:
          node-version: 16.13.0
          cache: 'npm'
          cache-dependency-path: ...

Given this configuration, could this setup be related to the issue discussed here?

Any insights or suggestions on whether this configuration might contribute to the problem would be greatly appreciated.

[kvnschlndt]

@zkochan It happens for runners which have not the latest version. We are also just using the ppm/action-setup and it happens. Has nothing to do with post-install.

[Codejune]

This is not a perfect solution, but to work around the current issue, we have resolved the error using the method below for now.

Specify the version as v4.0.0.

      ...
      - name: Set up pnpm
        uses: pnpm/action-setup@v4.0.0
        ...

[MikeMcC399]

The tags are mixed up.

The v4 tag https://github.com/pnpm/action-setup/tree/v4 is set to fc06bc1
The same as v5.0.0

The v4.4.0 https://github.com/pnpm/action-setup/releases/tag/v4.4.0 is also set to fc06bc1

It would probably be advisable to remove the v4.4.0 tag and release, and then set

the v4 tag to b906aff to make it point to
v4.3.0

As a workaround, the following will get you back to node20

uses: pnpm/action-setup@v4.3.0

$ git log --oneline -5
fc06bc1 (HEAD -> master, tag: v5.0.0, tag: v5, tag: v4.4.0, upstream/master, upstream/HEAD) feat!: run the action on Node.js 24 (#205)
b906aff (tag: v4.3.0) Revert "feat!: run the action on Node.js 24 (#205)"
9b5745c feat!: run the action on Node.js 24 (#205)
1e1c8ea ci: pin github actions (#199)
b9e1dbc fix(ci): exclude macos (#197)

[MikeMcC399]

This can't be fixed with a PR. It needs write access to the repo to clean things up.