build: fix fluentui imports for webpack #620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest version of Fluent UI specifies a list of exported modules in its package.json. Only these exports can be safely imported. With SPFx 1.19 and Webpack 5, using other exports will crash while creating the bundle. This PR updates the imports throughout the project to use the correct exports, which will allow the project to be used with the latest SPFx toolchain.
|
I've just seen #618 🤦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
The latest version of Fluent UI specifies a list of exported modules in its package.json. Only these exports can be safely imported. With SPFx 1.19 and Webpack 5, using other exports will crash while creating the bundle.
This PR updates the imports throughout the project to use the correct exports, which will allow the project to be used with the latest SPFx toolchain.