Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File Sorting not working on file size properly #501

Closed
1 of 3 tasks
HiltonGiesenow opened this issue Oct 6, 2022 · 1 comment · Fixed by #509
Closed
1 of 3 tasks

File Sorting not working on file size properly #501

HiltonGiesenow opened this issue Oct 6, 2022 · 1 comment · Fixed by #509
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Milestone
3.11.0

Comments

@HiltonGiesenow
Copy link
Contributor

Category

  • Enhancement
  • Bug
  • Question

Version

Please specify what version of the library you are using: [3.10.0]

Expected / Desired Behavior / Question

Sort on File Picker should work on file size.

Observed Behavior

Sort is not working on File Size properly. I think it's sorting as alpha, not numeric. Not sure why I didn't pick this up in my earlier PR, but might have just been too small a sample size.

Steps to Reproduce

On a library / folder with multiple file size, especially across multiple digits (e.g. 2 and 3 digit file sizes like "16kb" and "123kb"), sort by size.
@ghost
Copy link

ghost commented Oct 6, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Oct 6, 2022
@HiltonGiesenow HiltonGiesenow mentioned this issue Oct 6, 2022
Merged
AJIXuMuK added a commit that referenced this issue Nov 4, 2022
@AJIXuMuK
Merge pull request #502 from HiltonGiesenow/#501---Fix-for-file-size-…
341a53d 
…sort-not-working

Fix for issue #501 - File Size Sort not working (text based instead of numeric)
@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. and removed Needs: Triage 🔍 labels Nov 4, 2022
@AJIXuMuK AJIXuMuK added this to the 3.11.0 milestone Nov 4, 2022
@AJIXuMuK AJIXuMuK mentioned this issue Nov 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Projects
None yet
Milestone
3.11.0
Development

Successfully merging a pull request may close this issue.

3.11.0 pnp/sp-dev-fx-property-controls
2 participants
@HiltonGiesenow @AJIXuMuK