[V2] Fix default item selection in TreeView #864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…some children's keys are passed in as well to be default selected. Added way more flexibility to decide when in the lifecycle the children of a selected item should be selected too.
|
Thank you @YannickRe! |
|
I've also cherry-picked it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
Fixes the selection of children when passed in as
defaultSelectedKeys. Before, when a parent matched a key the children weren't checked any more if they were also part ofdefaultSelectedKeys. As a result, only the parent showed as selected. This is now fixed.Deprecated
selectChildrenIfParentSelectedand addedselectChildrenMode. This is a flagged enum which allows much more flexibility on when this before should be triggered. Currently, the behavior is triggered on mount, update (when new props are passed), select and unselect. As a result, you can never pass in the key of a parent and just one of its children as all of the children will be selected. With the change to a flagged enum, you can control all 4 lifetime moments separately.Old behavior can be replicated with
SelectChildrenMode.NoneandSelectChildrenMode.All. For more granular control can also be set to eg.SelectChildrenMode.Select | SelectChildrenMode.Unselect, which means that children will be selected/unselected when the parent is selected or unselected but not when the control mounts OR when the props are updated.