Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Return TermSetId for suggestions #762

Merged
merged 1 commit into from
Dec 12, 2020

Conversation

gautamdsheth
Copy link
Contributor

Q A
Bug fix? [x]
New feature? [ ]
New sample? [ ]
Related issues? NA

What's in this Pull Request?

In some cases, there is a weird behavior in the Taxonomy picker control.

If you select the term from the panel, it returns the termSetId of the selected Term.
If you use suggestions, then it doesn't happen but we get default Empty GUID. This causes some issues downstream if you want to use termSetId further.
This PR fixes that by sending back the termSetId in case of suggestions as well.

@AJIXuMuK AJIXuMuK merged commit a2281ac into pnp:dev Dec 12, 2020
@AJIXuMuK
Copy link
Collaborator

Thank you @gautamdsheth for the fix!

@AJIXuMuK AJIXuMuK added this to the 2.3.0 milestone Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants