Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add maxDate & minDate #552

Merged
merged 4 commits into from
May 24, 2020
Merged

Add maxDate & minDate #552

merged 4 commits into from
May 24, 2020

Conversation

PrasadKasireddy
Copy link
Contributor

Q A
Bug fix? [ ]
New feature? [X]
New sample? [ ]
Related issues? fixes #497

What's in this Pull Request?

To set DatePicker with date boundary (minDate, maxDate).

@PrasadKasireddy
Update IDateTimePickerState.ts
63713fc 
add max date and min date
@PrasadKasireddy
Update IDateTimePickerProps.ts
a6f18db 
add max & min date
@PrasadKasireddy
Update DateTimePicker.tsx
ea7e774 
add max & min dates
@PrasadKasireddy
Update DateTimePicker.md
371ad08 
add max and min date properties
@PrasadKasireddy
Copy link
Contributor Author

@AJIXuMuK - could you please review the PR

AJIXuMuK
AJIXuMuK requested changes May 15, 2020
View reviewed changes
Copy link
Collaborator

@AJIXuMuK AJIXuMuK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we just need to add minDate, maxDate optional values to the component and correctly pass the to the OUIFR DatePicker. No need for defaults. And no need for today in state.

src/controls/dateTimePicker/IDateTimePickerState.ts Show resolved Hide resolved
src/controls/dateTimePicker/DateTimePicker.tsx Show resolved Hide resolved
@AJIXuMuK AJIXuMuK merged commit 1797cd7 into pnp:dev May 24, 2020
@AJIXuMuK
Copy link
Collaborator

Hi @PrasadKasireddy - I've made additional changes and merged the PR.

Thanks for the contribution!

@AJIXuMuK AJIXuMuK added this to the 1.19.0 milestone May 24, 2020
@PrasadKasireddy
Copy link
Contributor Author

Hi @PrasadKasireddy - I've made additional changes and merged the PR.

Thanks for the contribution!

@AJIXuMuK Thanks

@PrasadKasireddy PrasadKasireddy deleted the PrasadKasireddy-patch-1 branch May 25, 2020 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AJIXuMuK AJIXuMuK AJIXuMuK requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@PrasadKasireddy @AJIXuMuK