Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge for 1.14.0 #335

Merged
merged 30 commits into from
Jul 17, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
11b0b74
Completed and fixed french translations, reordered based on mystrings…
May 23, 2019
188f58f
close popup when commitPopup sent (when click ok on new alert for exa…
May 23, 2019
aeddd6e
Add themeVariant and color props to WebPartTitle
May 25, 2019
8ff3a36
onClick and onDblClick should return void, not {}
Jun 4, 2019
9998229
Prep version 1.14.0
estruyf Jul 9, 2019
28d751f
Merge pull request #312 from Zhephyr54/fr-localization
estruyf Jul 9, 2019
e3124f5
Merge branch 'dev' of github.com:SharePoint/sp-dev-fx-controls-react …
estruyf Jul 9, 2019
8fec3e9
Change log updates
estruyf Jul 9, 2019
66798a1
Merge pull request #313 from ministainer/iframe-dialog-commit-popup
estruyf Jul 9, 2019
a33ae6b
Updated changelog
estruyf Jul 9, 2019
9c2eac0
#287 #314 - Fix for RichText view mode
estruyf Jul 9, 2019
e3de420
Updated changelog
estruyf Jul 9, 2019
66c1d07
Merge branch 'enhancement/258-webPartTitleSectionBackground' of https…
estruyf Jul 9, 2019
dda2df4
#316 - Removed color property
estruyf Jul 9, 2019
dfd83a5
Merge branch 'mpowney-enhancement/258-webPartTitleSectionBackground' …
estruyf Jul 9, 2019
7eab454
Updated changelog
estruyf Jul 9, 2019
14c49a2
Merge pull request #321 from AJIXuMuK/flr-onclick-return-type
estruyf Jul 9, 2019
b9926a9
Updated changelog
estruyf Jul 9, 2019
d6c8194
Merge branch 'dev' of github.com:SharePoint/sp-dev-fx-controls-react …
estruyf Jul 9, 2019
3b5d80f
#325 - Including wrapper class name for the SecurityTrimmedControl
estruyf Jul 9, 2019
c555d1d
Update changelog
estruyf Jul 9, 2019
02b1ddf
#319 - Added OData list filter
estruyf Jul 9, 2019
996f16f
Updated changelog
estruyf Jul 9, 2019
432a134
#315 - Fix for list selections after selecting list
estruyf Jul 9, 2019
3f2831f
Updated changelog
estruyf Jul 9, 2019
5d854d3
add german attachment and richText translations
DominikSchmieder Jul 10, 2019
f77ddfe
fixed german typo issues
DominikSchmieder Jul 10, 2019
befc024
Merge branch 'DominikSchmieder-patch-1' of https://github.com/Dominik…
estruyf Jul 17, 2019
d8d7738
#333 - Manual merge
estruyf Jul 17, 2019
985e50f
Updated changelog
estruyf Jul 17, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions CHANGELOG.JSON
Original file line number Diff line number Diff line change
@@ -1,5 +1,32 @@
{
"versions": [
{
"version": "1.14.0",
"changes": {
"new": [],
"enhancements": [
"German translations added for attachment and RichText controls [#333](https://github.com/SharePoint/sp-dev-fx-controls-react/pull/333)",
"`SecurityTrimmedControl`: Added a wrapper `className` property for the parent element [#325](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/325)",
"`ListPicker`: Add ability to filter the control via OData [#319](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/319)",
"`IFrameDialog`: closing dialog on commit [#313](https://github.com/SharePoint/sp-dev-fx-controls-react/pull/313)",
"`WebPartTitle` add support for section background color [#258](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/258)"
],
"fixes": [
"Fix in return type of onClick and onDoubleClick events [#321](https://github.com/SharePoint/sp-dev-fx-controls-react/pull/321)",
"`ListPicker`: Fix for available dropdown selection after selection was done [#315](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/315)",
"Fixes to French translations [#312](https://github.com/SharePoint/sp-dev-fx-controls-react/pull/312)",
"`RichText`: Issue on rendering the control in view mode [#287](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/287)"
]
},
"contributions": [
"[Amr Fouad](https://github.com/ministainer)",
"[Joel Jeffery](https://github.com/joeljeffery)",
"[Mark Powney](https://github.com/mpowney)",
"[Dominik Schmieder](https://github.com/DominikSchmieder)",
"[Alex Terentiev](https://github.com/AJIXuMuK)",
"[Zhephyr](https://github.com/Zhephyr54)"
]
},
{
"version": "1.13.2",
"changes": {
Expand Down
21 changes: 21 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,26 @@
# Releases

## 1.14.0

### Enhancements

- German translations added for attachment and RichText controls [#333](https://github.com/SharePoint/sp-dev-fx-controls-react/pull/333)
- `SecurityTrimmedControl`: Added a wrapper `className` property for the parent element [#325](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/325)
- `ListPicker`: Add ability to filter the control via OData [#319](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/319)
- `IFrameDialog`: closing dialog on commit [#313](https://github.com/SharePoint/sp-dev-fx-controls-react/pull/313)
- `WebPartTitle` add support for section background color [#258](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/258)

### Fixes

- Fix in return type of onClick and onDoubleClick events [#321](https://github.com/SharePoint/sp-dev-fx-controls-react/pull/321)
- `ListPicker`: Fix for available dropdown selection after selection was done [#315](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/315)
- Fixes to French translations [#312](https://github.com/SharePoint/sp-dev-fx-controls-react/pull/312)
- `RichText`: Issue on rendering the control in view mode [#287](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/287)

### Contributors

Special thanks to our contributors (in alphabetical order): [Amr Fouad](https://github.com/ministainer), [Joel Jeffery](https://github.com/joeljeffery), [Mark Powney](https://github.com/mpowney), [Dominik Schmieder](https://github.com/DominikSchmieder), [Alex Terentiev](https://github.com/AJIXuMuK), [Zhephyr](https://github.com/Zhephyr54).

## 1.13.2

### Enhancements
Expand Down
214 changes: 214 additions & 0 deletions de-de.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,214 @@
declare var define: any;

define([], () => {
return {
'SiteBreadcrumbLabel': 'Website Brotkrume',

'ListViewGroupEmptyLabel': 'Leer',

'WebPartTitlePlaceholder': 'Webpart Titel',
'WebPartTitleLabel': 'Titel hinzufügen',

'DateTime': {
'L_RelativeDateTime_AFewSecondsFuture': 'In wenigen Sekunden',
'L_RelativeDateTime_AFewSeconds': 'Vor wenigen Sekunden',
'L_RelativeDateTime_AboutAMinuteFuture': 'In ungefähr einer Minute',
'L_RelativeDateTime_AboutAMinute': 'Vor ungefähr einer Minute',
'L_RelativeDateTime_XMinutesFuture': 'In {0} Minute||In {0} Minuten',
'L_RelativeDateTime_XMinutes': 'Vor {0} Minute||Vor {0} Minuten',
'L_RelativeDateTime_XMinutesFutureIntervals': '1||2-',
'L_RelativeDateTime_XMinutesIntervals': '1||2-',
'L_RelativeDateTime_AboutAnHourFuture': 'In ungefähr einer Stunde',
'L_RelativeDateTime_AboutAnHour': 'Vor ungefähr einer Stunde',
'L_RelativeDateTime_Tomorrow': 'Morgen',
'L_RelativeDateTime_Yesterday': 'Gestern',
'L_RelativeDateTime_TomorrowAndTime': 'Morgen um {0}',
'L_RelativeDateTime_YesterdayAndTime': 'Gestern um {0}',
'L_RelativeDateTime_XHoursFuture': 'In {0} Stunde||In {0} Stunden',
'L_RelativeDateTime_XHours': 'Vor {0} Stunde||Vor {0} Stunden',
'L_RelativeDateTime_XHoursFutureIntervals': '1||2-',
'L_RelativeDateTime_XHoursIntervals': '1||2-',
'L_RelativeDateTime_DayAndTime': '{0} at {1}',
'L_RelativeDateTime_XDaysFuture': '{0} Tag ab jetzt||{0} Tage ab jetzt',
'L_RelativeDateTime_XDays': 'Vor {0} Tag||Vor {0} Tagen',
'L_RelativeDateTime_XDaysFutureIntervals': '1||2-',
'L_RelativeDateTime_XDaysIntervals': '1||2-',
'L_RelativeDateTime_Today': 'Heute'
},
'SendEmailTo': 'Email senden an {0}',
'StartChatWith': 'Chat starten mit {0}',
'Contact': 'Kontakt',
'UpdateProfile': 'Aktualisiere Dein Profil',

'TaxonomyPickerNoTerms': 'Ausdruckssatz enthält keine Ausdrücke',
'TaxonomyPickerExpandTitle': 'Ausdruckssatz erweitern',
'TaxonomyPickerMenuTermSet': 'Ausdruckssatz Menü',
'TaxonomyPickerInLabel': 'in',
'TaxonomyPickerTermSetLabel': 'Ausdruckssatz',

peoplePickerComponentTooltipMessage: 'People Picker',
peoplePickerComponentErrorMessage: 'Benutzerauswahl ist ein Pflichtfeld',
peoplePickerSuggestionsHeaderText: 'Vorgeschlagene Benutzer',
peoplePickerLoadingText: 'Laden',
PeoplePickerSearchText: 'Fetching users',
PeoplePickerGroupNotFound: 'Gruppe konnte nicht gefunden werden.',
ListItemPickerSelectValue: 'Wähle Wert',

mapsErrorMessage: 'Beim Laden von Karten ist ein Fehler aufgetreten',
mapsLoadingText: 'Laden',
mapsSearchButtonText: 'Suche',
mapsTitlePrefix: 'Karte von',

genericNoResultsFoundText: 'Kein Ergebnis gefunden',

ListViewFilterLabel: 'Filter',

ListItemAttachmentsActionDeleteIconTitle: 'Löschen',
ListItemAttachmentsactionDeleteTitle: 'Löschen',
ListItemAttachmentsfileDeletedMsg: 'Datei {0} gelöscht',
ListItemAttachmentsfileDeleteError: 'Fehler beim Löschen der Datei: {0}, Grund: {1}',
ListItemAttachmentserrorLoadAttachments: 'Fehler beim Laden der Anhänge, Grund: {0}',
ListItemAttachmentsconfirmDelete: 'Sind Sie sich sicher, dass Sie die Anlage {0} in den Papierkorb verschieben möchten ?',
ListItemAttachmentsdialogTitle: 'Listenelement-Anhang',
ListItemAttachmentsdialogOKbuttonLabel: 'Ok',
ListItemAttachmentsdialogCancelButtonLabel: 'Abbrechen',
ListItemAttachmentsdialogOKbuttonLabelOnDelete: 'Löschen',
ListItemAttachmentsuploadAttachmentDialogTitle: 'Anlage hinzufügen',
ListItemAttachmentsuploadAttachmentButtonLabel: 'Anlage hinzufügen',
ListItemAttachmentsuploadAttachmentErrorMsg: 'Die Datei {0} wurde nicht hinzugefügt, Grund: {1}',
ListItemAttachmentsCommandBarAddAttachmentLabel: 'Anlage hinzufügen',
ListItemAttachmentsloadingMessage: 'Datei wird hochgeladen ...',
ListItemAttachmentslPlaceHolderIconText: 'Listenelement-Anhang',
ListItemAttachmentslPlaceHolderDescription: 'Bitte Anlage hinzufügen',
ListItemAttachmentslPlaceHolderButtonLabel: 'Hinzufügen',

DatePickerMonthLongJanuary: 'Januar',
DatePickerMonthShortJanuary: 'Jan',
DatePickerMonthLongFebruary: 'Februar',
DatePickerMonthShortFebruary: 'Feb',
DatePickerMonthLongMarch: 'März',
DatePickerMonthShortMarch: 'Mar',
DatePickerMonthLongApril: 'April',
DatePickerMonthShortApril: 'Apr',
DatePickerMonthLongMay: 'Mai',
DatePickerMonthShortMay: 'Mai',
DatePickerMonthLongJune: 'Juni',
DatePickerMonthShortJune: 'Jun',
DatePickerMonthLongJuly: 'Juli',
DatePickerMonthShortJuly: 'Jul',
DatePickerMonthLongAugust: 'August',
DatePickerMonthShortAugust: 'Aug',
DatePickerMonthLongSeptember: 'September',
DatePickerMonthShortSeptember: 'Sept',
DatePickerMonthLongOctober: 'Oktober',
DatePickerMonthShortOctober: 'Okt',
DatePickerMonthLongNovember: 'November',
DatePickerMonthShortNovember: 'Nov',
DatePickerMonthLongDecember: 'Dezember',
DatePickerMonthShortDecember: 'Dez',
DatePickerDayLongSunday: 'Sonntag',
DatePickerDayShortSunday: 'So.',
DatePickerDayLongMonday: 'Montag',
DatePickerDayShortMonday: 'Mo.',
DatePickerDayLongTuesday: 'Dienstag',
DatePickerDayShortTuesday: 'Di.',
DatePickerDayLongWednesday: 'Mittwoch',
DatePickerDayShortWednesday: 'Mi.',
DatePickerDayLongThursday: 'Donnerstag',
DatePickerDayShortThursday: 'Do.',
DatePickerDayLongFriday: 'Freitag',
DatePickerDayShortFriday: 'Fr.',
DatePickerDayLongSaturday: 'Samstag',
DatePickerDayShortSaturday: 'Sa.',
DatePickerGoToToday: 'Heute',
DatePickerIsRequiredErrorMessage: '',
DatePickerInvalidInputErrorMessage: '',
DatePickerIsOutOfBoundsErrorMessage: '',
DateTimePickerDate: 'Datum',
DateTimePickerTime: 'Uhrzeit',
DateTimePickerTimeSeparator: ':',
DateTimePickerHourValueInvalid: 'Falscher Stundenwert',

HeaderNormalText: 'Normaler Text',
HeaderH2: 'Überschrift 1',
HeaderH3: 'Überschrift 2',
HeaderH4: 'Überschrift 3',
HeaderBlockQuote: 'Zitat',
AlignLeft: 'linksbündig',
AlignCenter: 'zentriert',
AlignRight: 'rechtsbündig',
AlignJustify: 'Blocksatz',
ListBullet: 'Aufzählungszeichen',
ListNumbered: 'Nummerierung',
StyleTitle: 'Schriftart',
BoldTitle: 'Fett (Strg+B)',
ItalicTitle: 'Kursiv (Strg+I)',
UnderlineTitle: 'Unterstrichen(Strg+U)',
AlignTitle: 'Ausrichtung',
ListTitle: 'Liste',
LinkTitle: 'Hyperlink',
MoreTitle: 'Mehr',
FormattingPaneTitle: 'Text Formattierung',
CloseButton: 'Schließen',
InsertLinkTitle: 'Link einfügen',
AddressFieldLabel: 'Adresse',
TextToDisplayLabel: 'Anzeigetext',
SaveButtonLabel: 'Speichern',
CancelButtonLabel: 'Abbrechen',
RemoveLinkLabel: 'Link entfernen',
ParagraphSectionTitle: 'Absatz',
HyperlinkSectionTitle: 'Hyperlink',
UndoTitle: 'Rückgängig',
RedoTitle: 'Wiederholen',
ClearFormattingTitle: 'Löschen',
FontStyleTitle: 'Schriftart',
FontSizeTitle: 'Schriftgröße',
StrikethroughTitle: 'durchgestrichen',
SuperscriptTitle: 'hochgestellt',
SubscriptTitle: 'tiefgestellt',
FontColorLabel: 'Schriftfarbe',
AutomaticFontColor: 'Automatisch',
HighlightColorLabel: 'Texthervorhebungsfarbe',
NoColorHighlightColor: 'Keine Farbe',
IncreaseIndentTitle: 'Einzug vergrößern',
DecreaseIndentTitle: 'Einzug verkleinern',
ThemeColorsGroupName: 'Themenfarbe',
HighlightColorsGroupName: 'Highlightfarben',
StandardColorsGroupName: 'Standardfarben',
ThemeColorDarker: 'Thema dunkler',
ThemeColorDark: 'Thema dunkel',
ThemeColorDarkAlt: 'Thema dunkler alternativ',
ThemeColorPrimary: 'Primäre Themafarbe',
ThemeColorSecondary: 'Sekundäre Themafarbe',
ThemeColorTertiary: 'Tertiäre Themafarbe',
ThemeColorNeutralSecondary: 'Sekundäre neutrale Themafarbe',
ThemeColorNeutralPrimaryAlt: 'Primäre alternative neutrale Themafarbe',
ThemeColorNeutralPrimary: 'Primäre neutrale Themafarbe',
ThemeColorNeutralDark: 'Neutrale dunkle Themafarbe',
HighlightColorYellow: 'Gelb',
HighlightColorGreen: 'Grün',
HighlightColorAqua: 'Aqua',
HighlightColorMagenta: 'Magenta',
HighlightColorBlue: 'Blau',
HighlightColorRed: 'Rot',
HighlightColorDarkblue: 'Dunkelblau',
HighlightColorTeal: 'Blaugrün',
HighlightColorDarkgreen: 'Dunkelgrün',
HighlightColorPurple: 'Lila',
HighlightColorMaroon: 'Braun',
HighlightColorGold: 'Gold',
HighlightColorDarkgrey: 'Dunkelgrau',
HighlightColorGrey: 'Grau',
HighlightColorBlack: 'Schwarz',
StandardColorDarkred: 'Dunkelrot',
StandardColorRed: 'Rot',
StandardColorOrange: 'Orange',
StandardColorYellow: 'Gelb',
StandardColorLightgreen: 'Hellgrün',
StandardColorGreen: 'Grün',
StandardColorLightblue: 'Hellblau',
StandardColorBlue: 'Blau',
StandardColorDarkblue: 'Dunkelblau',
StandardColorPurple: 'Lila'
};
});
21 changes: 21 additions & 0 deletions docs/documentation/docs/about/release-notes.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,26 @@
# Releases

## 1.14.0

### Enhancements

- German translations added for attachment and RichText controls [#333](https://github.com/SharePoint/sp-dev-fx-controls-react/pull/333)
- `SecurityTrimmedControl`: Added a wrapper `className` property for the parent element [#325](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/325)
- `ListPicker`: Add ability to filter the control via OData [#319](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/319)
- `IFrameDialog`: closing dialog on commit [#313](https://github.com/SharePoint/sp-dev-fx-controls-react/pull/313)
- `WebPartTitle` add support for section background color [#258](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/258)

### Fixes

- Fix in return type of onClick and onDoubleClick events [#321](https://github.com/SharePoint/sp-dev-fx-controls-react/pull/321)
- `ListPicker`: Fix for available dropdown selection after selection was done [#315](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/315)
- Fixes to French translations [#312](https://github.com/SharePoint/sp-dev-fx-controls-react/pull/312)
- `RichText`: Issue on rendering the control in view mode [#287](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/287)

### Contributors

Special thanks to our contributors (in alphabetical order): [Amr Fouad](https://github.com/ministainer), [Joel Jeffery](https://github.com/joeljeffery), [Mark Powney](https://github.com/mpowney), [Dominik Schmieder](https://github.com/DominikSchmieder), [Alex Terentiev](https://github.com/AJIXuMuK), [Zhephyr](https://github.com/Zhephyr54).

## 1.13.2

### Enhancements
Expand Down
1 change: 1 addition & 0 deletions docs/documentation/docs/controls/ListPicker.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ The `ListPicker` control can be configured with the following properties:
| className | string | no | If provided, additional class name to provide on the dropdown element. |
| disabled | boolean | no | Whether or not the control is disabled. |
| baseTemplate | number | no | The SharePoint BaseTemplate ID to filter the list options by. |
| filter | string | no | Filter list from OData query (takes precendents over Hidden and BaseTemplate Filters). |
| includeHidden | boolean | no | Whether or not to include hidden lists. Default is `true`. |
| orderBy | LibsOrderBy | no | How to order the lists retrieved from SharePoint. |
| selectedList | string OR string[] | no | Keys of the selected item(s). If you provide this, you must maintain selection state by observing onSelectionChanged events and passing a new value in when changed. |
Expand Down
3 changes: 3 additions & 0 deletions docs/documentation/docs/controls/SecurityTrimmedControl.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ The `SecurityTrimmedControl` can be configured with the following properties:
| level | PermissionLevel | yes | Specify where to check the user permissions: current site or list / remote site or list. |
| remoteSiteUrl | string | no | The URL of the remote site. Required when you want to check permissions on remote site or list. |
| relativeLibOrListUrl | string | no | The relative URL of the list or library. Required when you want to check permissions on remote list. |
| folderPath | string | no | Specify the name of a folder to check the user permissions against. Will be overridden if itemId is present. |
| itemId | number | no | Specify the ID of the item to check the user permissions against. Takes precedence over folder. |
| className | string | no | Specify the className to be used on the parent element. |

The `PermissionLevel` enum has the following values:

Expand Down
3 changes: 2 additions & 1 deletion docs/documentation/docs/controls/WebPartTitle.md
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ The WebPartTitle control can be configured with the following properties:
| updateProperty | Function | yes | Function that you can pass to update the title in the root web part. |
| className | string | no | Optional property to specify a custom class that allows you to change the web part title style. |
| placeholder | string | no | Optional property to specify a custom placeholder to display when the title is editable. |
| moreLink | Function \| JSX.Element | no | Optional property to render a _See all_ link in the web part title. |
| themeVariant | IReadonlyTheme | no | The current loaded SharePoint theme/section background (More info: [Supporting section backgrounds](https://docs.microsoft.com/en-us/sharepoint/dev/spfx/web-parts/guidance/supporting-section-backgrounds)). |
| moreLink | Function \| JSX.Element | no | Optional property to render a _See all_ link in the web part title. |

![](https://telemetry.sharepointpnp.com/sp-dev-fx-controls-react/wiki/controls/WebPartTitle)
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@pnp/spfx-controls-react",
"description": "Reusable React controls for SharePoint Framework solutions",
"version": "1.13.2",
"version": "1.14.0",
"engines": {
"node": ">=0.10.0"
},
Expand Down
2 changes: 1 addition & 1 deletion src/common/telemetry/version.ts
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export const version: string = "1.13.2";
export const version: string = "1.14.0";
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export interface IFieldLookupRendererProps extends IFieldRendererProps {
/**
* custom event handler of lookup item click. If not set the dialog with Display Form will be shown
*/
onClick?: (args: IFieldLookupClickEventArgs) => {};
onClick?: (args: IFieldLookupClickEventArgs) => void;
/**
* Field's id.
*/
Expand Down
6 changes: 3 additions & 3 deletions src/controls/fields/fieldNameRenderer/FieldNameRenderer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,19 +31,19 @@ export interface IFieldNameRendererProps extends IFieldRendererProps {
isNew?: boolean;
/**
* true if the document type has preview (true by default).
* The flag impacts on the link's href:
* The flag impacts on the link's href:
* if the flag is tru then the href is constructed like #id=${filePath}&parent=${filePath.substring(0, filePath.lastIndexOf('/'))},
* otherwise the href will contain filePath only.
*/
hasPreview?: boolean;
/**
* custom handler for link click. If not set link click will lead to rendering document preview
*/
onClick?: (args: IFieldNameClickEventArgs) => {};
onClick?: (args: IFieldNameClickEventArgs) => void;
/**
* custom handler for link double click. If not set link will use OOTB behavior.
*/
onDoubleClick?: (args: IFieldNameClickEventArgs) => {};
onDoubleClick?: (args: IFieldNameClickEventArgs) => void;
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export interface IFieldTitleRendererProps extends IFieldRendererProps {
/**
* custom title click event handler. If not set Display form for the item will be displaed
*/
onClick?: (args: IFieldTitleClickEventArgs) => {};
onClick?: (args: IFieldTitleClickEventArgs) => void;
}

/**
Expand Down
1 change: 1 addition & 0 deletions src/controls/iFrameDialog/IFrameDialogContent.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ export class IFrameDialogContent extends React.Component<IIFrameDialogContentPro
private _iframeOnLoad(): void {
try { // for cross origin requests we can have issues with accessing frameElement
this._iframe.contentWindow.frameElement.cancelPopUp = this.props.close;
this._iframe.contentWindow.frameElement.commitPopUp = this.props.close;
}
catch (err) {
if (err.name !== 'SecurityError') {
Expand Down
Loading