Readonly fix for _wrapperRef in componentDidMount #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
=======================================
Coverage 72.84% 72.84%
=======================================
Files 17 17
Lines 766 766
Branches 148 148
=======================================
Hits 558 558
Misses 161 161
Partials 47 47Continue to review full report at Codecov.
|
estruyf
added a commit
that referenced
this pull request
Jul 9, 2019
|
Thanks @joeljeffery for this change. I manually added it, as there were a lot of formatting changes applied in this PR. This will be available in version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
There's a tiny bug in componentDidMount in RichText.tsx.
The bug causes the RichText control not to render in view mode.
_wrapperRef only gets defined in edit mode; so the whole contents of componentDidMount should be only executed if we're in edit mode.