Iframe dialog commit popup #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge for 1.13.0
Merge for 1.13.1
Merge for 1.13.2
Codecov Report
@@ Coverage Diff @@
## dev #313 +/- ##
=======================================
Coverage 72.84% 72.84%
=======================================
Files 17 17
Lines 766 766
Branches 148 158 +10
=======================================
Hits 558 558
Misses 161 161
Partials 47 47Continue to review full report at Codecov.
|
|
@estruyf not sure if you had a chance to look at this PR |
|
Thanks @ministainer, this will be available in version |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
Very minor update to the IFrameDialogContent component that enables Iframedialog to be correctly closed when the user clicks OK on a SharePoint out of the box pages hosted within the iframe element.
an example is /_layouts/15/SubNew.aspx (popup appears when alert me button is clicked)