🐛 - Fixes-Issue 1953 - DynamicForm required User Fields not checked before submit (Repo Rescuer Challenge)

[NishkalankBezawada]

Q	A
Bug fix?	[x]
New feature?	[ ]
New sample?	[ ]
Related issues?	fixes #1953

What's in this Pull Request?

Fix for Issue 1953

Observation

Required field validation is not working for User field (both single and multi select) as in below screens

Actual behavior

Required field validation should work for all the fields.

Solution

Upon further investigation, I discovered that the value for an empty user field is [''], and the validation fails when attempting to verify isEmptyArray because the value.length is 1. The following method consistently fails

  private isEmptyArray(value): boolean {
    return Array.isArray(value) && value.length === 0;
  }

Including an additional userFields check as shown below

  private checkUserArrayIsEmpty = (value): boolean => {
    return Array.isArray(value) && value.every(item => item === "");
  }

which, in fact, verifies that each string in the array is empty, resuming the validation.

Verification

Thanks,
Nish

[NishkalankBezawada]

Hey @michaelmaillot @joaojmendes,

All set for your review.

Thanks,
Nish

[AJIXuMuK]

hey @NishkalankBezawada there is a conflict after merging your last PR.
Could you please resolve it?

Thanks!

[NishkalankBezawada]

hey @NishkalankBezawada there is a conflict after merging your last PR.

Could you please resolve it?

Thanks!

On it now 💪

[NishkalankBezawada]

hey @NishkalankBezawada there is a conflict after merging your last PR. Could you please resolve it?

Thanks!

Hey @AJIXuMuK

Thanks for your review and suggestion.

I have now resolved the conflict accordingly.

Thanks,
Nish

[AJIXuMuK]

Thank you!
Merged!