Skip to content

Fix #1874: ListItemComments - can't select text from comment #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Ateina
Copy link
Contributor

@Ateina Ateina commented Oct 25, 2024

Q A
Bug fix? [ X]
New feature? [ ]
New sample? [ ]
Related issues? fixes #1874

What's in this Pull Request?

Currently, ListItemComments uses Document Card as its container, which has user-select set to none. In comparison, SharePoint’s OOTB comments allow users to select and copy text. It would enhance usability to enable text selection here as well.

@joelfmrodrigues joelfmrodrigues merged commit 7e5439a into pnp:dev Dec 10, 2024
1 check passed
@joelfmrodrigues
Copy link
Collaborator

@Ateina many thanks! This is now merged and should be in the beta release within a few minutes

@joelfmrodrigues joelfmrodrigues added this to the 3.21.0 milestone Dec 10, 2024
@Ateina Ateina deleted the 1874-ListItemComments-select-text-from-comment branch April 26, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants