Skip to content

Carousel: make buttonLocation and buttonDisplay optional, add contentHeight property #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2024
Merged

Carousel: make buttonLocation and buttonDisplay optional, add contentHeight property #1801

merged 1 commit into from
Apr 2, 2024

Conversation

AJIXuMuK
Copy link
Collaborator

@AJIXuMuK AJIXuMuK commented Apr 2, 2024

Q A
Bug fix? [ ]
New feature? [x]
New sample? [ ]
Related issues? no

What's in this Pull Request?

The PR contains changes to the Carousel component:

  • buttonLocation is now optional. Default value is center.
  • buttonDisplay is now optional. Default value is block.
  • new property contentHeight is added. It can be used instead of contentContainerStyle to specify the height for the slide's content.

Guidance

  • You can delete this section when you are submitting the pull request.
  • Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.
  • Please target your PR to dev branch.

@AJIXuMuK AJIXuMuK merged commit 259ef80 into dev Apr 2, 2024
@AJIXuMuK AJIXuMuK deleted the carousel-defaults branch April 2, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AJIXuMuK