Fix - Issue 1592 - Dynamic form - Number validations are working, but the percentage values are not getting saved

[NishkalankBezawada]

Q	A
Bug fix?	[x]
New feature?	[ ]
New sample?	[ ]
Related issues?	fixes #1592

What's in this Pull Request?

Fix for issue #1592

Problem

The number validations are working like a charm, but if we are using a percentage column and trying to save the value to that column, it is not saving the values. Below is the screen for the validations

Steps to Reproduce

1. Add field Number and choose as 'Show as percentage'
2. Use this list in Dynamic form, with New Item, and give the value as 15 and click save
   The form will not be saved.

Solution

The properties number field if chosen as 'Shown as percentage', the minimum and maximum values will be retrieved as below,

wherein, the properties of number field without choosing 'Show as percentage', the minimum and maximum values will be retrieved as below.

And at onSubmitClick, the validation for percentage column is failing due to the minimum and maximum values for the percentage column.

While validating a number, the percentage column is validated as below,

While onSubmit the same validation for the percentage column is not done, instead, the minimum value and maximum value is checked with the default values as 0.1 and 1 respectively.

So, a new method is introduced to check the validation again while the user is submitting the form as below,

Thanks,
Nishkalank

[michaelmaillot]

Hi @NishkalankBezawada,

Thanks for this fix!

I've requested a few little things to update, can you have a look at them?

[NishkalankBezawada]

Hi @NishkalankBezawada,

Thanks for this fix!

I've requested a few little things to update, can you have a look at them?

Hey @michaelmaillot

Sure thing, I'll do it early tomorrow in the morning 😊

Thanks for the review.
Nishkalank

[michaelmaillot]

Merged manually.

Thank you @NishkalankBezawada!

[NishkalankBezawada]

Merged manually.

Thank you @NishkalankBezawada!

Thanks a lot @michaelmaillot