Fixes DynamicForm trying to load TaxonomyFields with wrong display name. Closes #1422 #1479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinlingstuyl
force-pushed
the
fix-taxonomy-field-issue
branch
from
720939a to
0e68bfe
Compare
martinlingstuyl
force-pushed
the
fix-taxonomy-field-issue
branch
from
0e68bfe to
8c2f768
Compare
|
@martinlingstuyl many thanks! Merged |
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
Fixes an issue with Taxonomy Fields concerning the relation between Taxonomy Fields and their corresponding note fields. The corresponding note field internal name was retrieved by assuming that the Display Name of that note field was equal to the internal name of the Taxonomy field and
_0.So for example:
If the taxonomy field has an internal fieldname called
Project, the display name of the note field was inferred to beProject_0. This is actually a correct assumption in most cases. When creating a Column using the SharePoint UI for example.But there are scenario's when this is incorrect. For example when fields are provisioned using automated solutions, it's possible for these field titles to have received different values.
It's better to retrieve the field by Id. And this ID is also present in the details of the field in the form of the
TextFieldproperty.