Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix of #131, #132, spinner while loading iframe content #133

Merged
merged 1 commit into from
Sep 20, 2018

Conversation

AJIXuMuK
Copy link
Collaborator

Q A
Bug fix? [x]
New feature? [ ]
New sample? [ ]
Related issues? #131, #132

What's in this Pull Request?

@codecov-io
Copy link

Codecov Report

Merging #133 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #133   +/-   ##
=======================================
  Coverage   80.63%   80.63%           
=======================================
  Files          10       10           
  Lines         346      346           
  Branches       78       71    -7     
=======================================
  Hits          279      279           
  Misses         44       44           
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f74bdb...0d3aad6. Read the comment docs.

@estruyf estruyf merged commit 0d3aad6 into pnp:dev Sep 20, 2018
@estruyf
Copy link
Member

estruyf commented Sep 20, 2018

Thanks @AJIXuMuK for this PR it will be available in 1.9.0.

@estruyf estruyf added this to the 1.9.0 milestone Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants