Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

People picker source site #111

Merged
merged 3 commits into from
Sep 6, 2018

Conversation

joelfmrodrigues
Copy link
Collaborator

Q A
Bug fix? [ ]
New feature? [X]
New sample? [ ]
Related issues? mentioned in #110

What's in this Pull Request?

Added a new property to people picker (webAbsoluteUrl) that allows for a web url to be specified.
If specified, users will be retrieved from that site. Otherwise, default to current site (current behaviour)

@codecov-io
Copy link

Codecov Report

Merging #111 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #111   +/-   ##
=======================================
  Coverage   80.63%   80.63%           
=======================================
  Files          10       10           
  Lines         346      346           
  Branches       71       78    +7     
=======================================
  Hits          279      279           
  Misses         44       44           
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3daeac4...2a51cf5. Read the comment docs.

@estruyf estruyf merged commit 2a51cf5 into pnp:dev Sep 6, 2018
@estruyf
Copy link
Member

estruyf commented Sep 6, 2018

@joelfmrodrigues thanks for this PR, it got merged and planned for version 1.8.0.

@joelfmrodrigues joelfmrodrigues deleted the people-picker-source-site branch February 9, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants