Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateTime Picker noon/midnight issue with 12 hour format #576

Closed
c-eiser13 opened this issue Jun 5, 2020 · 2 comments · Fixed by #577
Closed

DateTime Picker noon/midnight issue with 12 hour format #576

c-eiser13 opened this issue Jun 5, 2020 · 2 comments · Fixed by #577
Labels
status:fixed Issue fixed in current or prior release. type:bug
Milestone

Comments

@c-eiser13
Copy link
Contributor

Category

[ ] Enhancement

[X ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ 1.18.0 ]

Expected / Desired Behavior / Question

When 12AM and 12PM are chosed in the drop down, returns date object with proper time value.

Observed Behavior

When selecting time in the drop down, if 12 PM is chosen, date is returned as midnight (12AM) and if 12 AM is selected in drop down, noon (12PM) is returned.

datetimepicker
datetimepicker2

datetimepickeram1
datetimepickeram2

I believe the only change needed is switching pm in the if statement to am. I believe this is the same or a similar issue to #402. I will test this fix then create a PR for review.

Steps to Reproduce

Use DateTime picker with 12 hour format and select 12PM or 12AM and view date object.

@ghost
Copy link

ghost commented Jun 5, 2020

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Jun 5, 2020
c-eiser13 added a commit to c-eiser13/sp-dev-fx-controls-react that referenced this issue Jun 5, 2020
@AJIXuMuK AJIXuMuK added status:fixed Issue fixed in current or prior release. type:bug and removed Needs: Triage 🔍 labels Jun 16, 2020
@AJIXuMuK AJIXuMuK added this to the 1.19.0 milestone Jun 16, 2020
@AJIXuMuK
Copy link
Collaborator

The issue has been resolved and will be available in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed Issue fixed in current or prior release. type:bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants