-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW CONTROL - Adaptive Card Host #1096
Comments
Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible. |
Thank you for submitting your first issue to this project. |
Hi @fabiofranzini , that would be a great addition in my opinion. I was actually discussing this with @joaojmendes a few days ago as he was considering a similar control. Perhaps we could use this thread as a starting point to avoid duplication of effort and duplicated PRs? Are you both able to describe your approach so we could all brainstorm the best way to move this forward and hopefully benefit from both solutions? |
Hi @joelfmrodrigues, The idea is to have a control that can host Adaptive Cards in both Web Parts and Application Customizer, so that they can be used as a UI. Also, as I have already implemented in some examples, we could extend the Adaptive Cards 'standard' set of controls with Fluent UI controls or as suggested by @joaojmendes with Microsoft Graph Toolkit controls. @joaojmendes, we need to set up a call to discuss this :) |
@fabiofranzini @joaojmendes - also keep in mind there is a web part sample with AC host. |
Hi @AJIXuMuK, yes and thanks for the suggestion! The purpose is to create a reusable control and extend the common set of controls that come from Adaptive Cards. |
Hi, all,
I think that we can accept the control of @fabiofranzini and the new improvements will be implemented on that .
Thanks
João
From: Fabio Franzini ***@***.***>
Date: Tuesday, 18 January 2022 at 16:24
To: pnp/sp-dev-fx-controls-react ***@***.***>
Cc: João Mendes ***@***.***>, Mention ***@***.***>
Subject: Re: [pnp/sp-dev-fx-controls-react] NEW CONTROL - Adaptive Card Host (Issue #1096)
Hi @AJIXuMuK<https://github.com/AJIXuMuK>, yes and thanks for the suggestion! The purpose is to create a reusable control and extend the common set of controls that come from Adaptive Cards.
—
Reply to this email directly, view it on GitHub<#1096 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AC7YHVP6HWRVMCJMS5TOYE3UWWH2BANCNFSM5MFGDKJQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Tomorrow I and @joaojmendes will synchronize and let's see how to collaborate on this component 👍 |
Hello,
I've been working with Adaptive Cards, I really like the new ACE model and in general I like the fact that I can describe the UI of a Web Part in a declarative way and be able to change it at runtime, like a configuration.
After some tests on this, I created a React control that allows you to render an Adaptive Card as a component, also using the templating part and the ability to invoke commands defined using the "Action.Execute" model.
I would like to make it a control of this library, what do you think?
The text was updated successfully, but these errors were encountered: