Handle folders bigger than 2 GB in Get-PnPTeamsChannelFilesFolder #4127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jackpoz , good catch , have merged it ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Related Issues?
Fixes #4126
What is in this Pull Request ?
Handle folders bigger than 2 GB in Get-PnPTeamsChannelFilesFolder.
The Graph documentation of driveItem type returned by /teams/{id}/channels/{id}/filesFolder specifies
Int64as type ofsizeproperty. Usinglongto follow the PnP PowerShell current standard.Tests
Before the PR Get-PnPTeamsChannelFilesFolder shows nothing as the exception is swallowed if the channel has more than 2147483647 bytes (or around 2 GB):
Debugging shows the exception message "The JSON value could not be converted to System.Int32. Path: $.size":
With the PR the cmdlet shows the response:
