Skip to content

Fixing Get-PnPChangeLog -Version not returing data #3804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Fixing Get-PnPChangeLog -Version not returing data #3804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a9039c
Fixing -Version not working
KoenZomers Mar 1, 2024
d516e58
Adding changelog entry
KoenZomers Mar 1, 2024
80db174
Adding PR reference
KoenZomers Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,14 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).

### Added

### Fixed

- Fixed `Get-PnPChangeLog -Version 2.3.0` not returning the changelog for that version [#3804](https://github.com/pnp/powershell/pull/3804)

### Contributors

- Koen Zomers [koenzomers]

## [2.4.0]

### Added
Expand Down
2 changes: 1 addition & 1 deletion src/Commands/Base/GetChangeLog.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ protected override void ProcessRecord()

if (MyInvocation.BoundParameters.ContainsKey(nameof(Release)))
{
var url = $"https://api.github.com/repos/pnp/powershell/releases/tags/{Release.Major}.{Release.Minor}.{Release.Build}";
var url = $"https://api.github.com/repos/pnp/powershell/releases/tags/v{Release.Major}.{Release.Minor}.{Release.Build}";
var response = client.GetAsync(url).GetAwaiter().GetResult();
if (response.IsSuccessStatusCode)
{
Expand Down