Skip to content

Change Set-PnPWebhookSubscription to use the same defualt expiration date as Add-PnPWebhookSubsription #3106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2023
Merged

Change Set-PnPWebhookSubscription to use the same defualt expiration date as Add-PnPWebhookSubsription #3106

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0892a43
Fix Set-PnPWebhookSubscription to use same max range as Add-PnPWebhoo…
reusto May 12, 2023
ce84ebb
Merge branch 'dev' into bugfix/updateWebhook6Months
gautamdsheth May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Commands/Webhooks/SetWebhookSubscription.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ namespace PnP.PowerShell.Commands.Webhooks
[OutputType(typeof(WebhookSubscription))]
public class SetWebhookSubscription : PnPWebCmdlet
{
public const int DefaultValidityInMonths = 6;
public const int DefaultValidityInDays = 180; // Note: the max is 180 days not 6 months - https://learn.microsoft.com/sharepoint/dev/apis/webhooks/overview-sharepoint-webhooks
public const int ValidityDeltaInDays = -72; // Note: Some expiration dates too close to the limit are rejected

[Parameter(Mandatory = true, ValueFromPipeline = true, Position = 0)]
public WebhookSubscriptionPipeBind Subscription;

Expand All @@ -24,7 +24,7 @@ public class SetWebhookSubscription : PnPWebCmdlet
public string NotificationUrl;

[Parameter(Mandatory = false)]
public DateTime ExpirationDate = DateTime.Today.ToUniversalTime().AddMonths(DefaultValidityInMonths).AddHours(ValidityDeltaInDays);
public DateTime ExpirationDate = DateTime.Today.ToUniversalTime().AddDays(DefaultValidityInDays).AddHours(ValidityDeltaInDays);

protected override void ExecuteCmdlet()
{
Expand Down