Skip to content

Conversation

KoenZomers
Copy link
Collaborator

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

N/A

What is in this Pull Request ?

Changed that https:// prefix is no longer required when using Connect-PnPOnline -Url tenant.sharepoint.com to save some typing. It still supports adding it for backwards compatibility, i.e. Connect-PnPOnline -Url https://tenant.sharepoint.com will still work as well.

@gautamdsheth
Copy link
Collaborator

Hi @KoenZomers , realized that we can't do this because we support page transformation. Now page transformation can happen from OnPrem to Online or Online to Online. In case of Online-to-Online transformation, this would be fine. In case of the OnPrem, there could be cases where the URLs might begin with http , so would break those scenarios.

Thoughts ?

@KoenZomers
Copy link
Collaborator Author

@gautamdsheth the code change allows http:// and https:// to be used as a prefix, in which case it will not do anything different than it does today. See:

https://github.com/pnp/powershell/pull/2139/files#diff-b885630f1a0a48bcc067ae40d2b76ed6517cdfe18b22450581be1dedbba66ad0R236

@gautamdsheth gautamdsheth merged commit 234897f into pnp:dev Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants