-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OData lambda style filter query #3155
Open
Tanddant
wants to merge
26
commits into
pnp:version-4
Choose a base branch
from
Tanddant:v4-ODataFilterQuery
base: version-4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solved the issue where if you reused the same variable name in your long queries it broke
This reverts commit fc6fd40.
down to one warning which I can't resolve
# Conflicts: # package-lock.json # packages/sp/spqueryable.ts
await sp.web.webinfos.filter(w => w.text("Title").equal('MyWebTitle'))();
Latest commit added "auto typing" for things like lists, webs, and so on, where we "know the type" I.e await sp.web.webinfos.filter(w => w.text("Title").equal('MyWebTitle'))(); Without having to specify that I haven't tested this in every possible combination, but it looks to be working without breaking the list item stuff, should greatly improve the usability 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category
Related Issues
Based off the discussion over on #2781
What's in this Pull Request?
This PR is not completely done, but I needed a place to track the final changes (and docs) based off the input in #2781
.eq(...)
alongside the others, would like opinionsI'll happily start updating the docs once we have a "somewhat sign-off" on the above been done to an acceptable state 😊