Migrates to Zod v4 #7005
Merged
Migrates to Zod v4 #7005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinM85
reviewed
Oct 16, 2025
Contributor
MartinM85
left a comment
MartinM85
left a comment
There was a problem hiding this comment.
Quick review. Nothing major, but maybe I overlooked something.
src/m365/entra/commands/roledefinition/roledefinition-remove.ts
Outdated
Show resolved
Hide resolved
Member
Author
|
Thanks for the feedback @MartinM85! Very keen eye! |
waldekmastykarz
force-pushed
the
zod4
branch
from
a86f242 to
4138dd6
Compare
MartinM85
requested changes
Nov 26, 2025
Contributor
MartinM85
left a comment
MartinM85
left a comment
There was a problem hiding this comment.
Just a few minor suggestions from my side...using z.uuid() instead of z.string() in several commands.
Member
Author
|
Thanks @MartinM85. I wanted to keep the migration limited to just the necessary changes, but we can include the improvements you suggested too. |
Contributor
Hi @waldekmastykarz, in that case just ignore my suggestions. |
waldekmastykarz
force-pushed
the
zod4
branch
from
4138dd6 to
ce148db
Compare
waldekmastykarz
force-pushed
the
zod4
branch
from
713038e to
fe31e6a
Compare
MartinM85
approved these changes
Dec 22, 2025
Contributor
MartinM85
left a comment
MartinM85
left a comment
There was a problem hiding this comment.
Great work @waldekmastykarz 🚀
Approved. I will merge it manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.