-
Notifications
You must be signed in to change notification settings - Fork 370
New command: spo list defaultvalue get. Closes #6535 #6967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you for opening the PR 👏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new command spo list defaultvalue get to retrieve a specific default column value from a SharePoint document library. The command supports retrieval by list ID, title, or URL, and can optionally filter by folder location.
Key Changes:
- Added new command to retrieve default column values from a document library
- Implemented XML parsing for SharePoint's client_LocationBasedDefaults.html file
- Added comprehensive test coverage with multiple scenarios including error handling
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/m365/spo/commands/list/list-defaultvalue-get.ts | Core command implementation with XML parsing and API integration |
| src/m365/spo/commands/list/list-defaultvalue-get.spec.ts | Comprehensive test suite covering all command scenarios |
| src/m365/spo/commands.ts | Command registration in the commands list |
| docs/src/config/sidebars.ts | Documentation navigation entry |
| docs/docs/cmd/spo/list/list-defaultvalue-get.mdx | User-facing command documentation |
| .devproxy/api-specs/sharepoint.yaml | API endpoint specifications for dev proxy |
Adam-it
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅Tested locally works perfectly
@Ateina amaizing work 😍
I don't have much to add. I only added two comments which will improve the reusability of our codebase. Please consider them before we proceed.
Copilot also noticed some minor things we could fixup.
Other than that seems very solid 👍
You Rock 🤩
|
@Adam-it Thank you for the review 💚 |
|
@Ateina I saw you added a commit with a fixup I guess. If you think the PR is read for another go and to be merged use the |
|
@Ateina I just noticed your reply to one of my comments when doing the review. So sorry I did not respond sooner. |
…Json) into a shared utility utils/spo.ts
|
@Adam-it Thank you 💚 |
Closes #6535