Adds interactivity for planner commands #5909
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milanholemans
force-pushed
the
planner-interactivity
branch
2 times, most recently
from
1df3dd1
to
47f8e12
Compare
martinlingstuyl
requested changes
May 3, 2024
There was a problem hiding this comment.
Hi @milanholemans, great work! This cleans up nicely. I do have some comments. Could you look at them?
milanholemans
force-pushed
the
planner-interactivity
branch
from
47f8e12
to
49f72ab
Compare
milanholemans
force-pushed
the
planner-interactivity
branch
from
49f72ab
to
eb919f0
Compare
martinlingstuyl
approved these changes
May 5, 2024
|
Merged manually, thank you! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5902
In this PR
getIdutil functions instead of fetching the entire object when only the ID is needed.