Fixes serializing bool values in CSV output. Closes #6326

pnp · Sep 15, 2024 · dc99e61 · dc99e61
1 parent 7717450
commit dc99e61
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/Command.spec.ts b/src/Command.spec.ts
@@ -601,6 +601,18 @@ describe('Command', () => {
     assert(actual.indexOf(JSON.stringify(commandOutput[0].property)) === -1);
   });
 
+  it('correctly serialize bool values to csv output', async () => {
+    const command = new MockCommand1();
+    const commandOutput = [
+      {
+        'property1': true,
+        'property2': false
+      }
+    ];
+    const actual = await command.getCsvOutput(commandOutput, { options: { output: 'csv' } });
+    assert.strictEqual(actual,"property1,property2\n1,0\n");
+  });
+
   it('passes validation when csv output specified', async () => {
     const cmd = new MockCommand2();
     assert.strictEqual(await cmd.validate({ options: { output: 'csv' } }, cli.getCommandInfo(cmd)), true);

diff --git a/src/Command.ts b/src/Command.ts
@@ -682,7 +682,10 @@ export default abstract class Command {
       quote: cli.getConfig().get(settingsNames.csvQuote),
       quoted: cli.getSettingWithDefaultValue<boolean>(settingsNames.csvQuoted, false),
       // eslint-disable-next-line camelcase
-      quoted_empty: cli.getSettingWithDefaultValue<boolean>(settingsNames.csvQuotedEmpty, false)
+      quoted_empty: cli.getSettingWithDefaultValue<boolean>(settingsNames.csvQuotedEmpty, false),
+      cast: {
+        boolean: (value: boolean) => value ? '1' : '0'
+      }
     });
   }