This repository has been archived by the owner on Jan 19, 2021. It is now read-only.
Fix: Modern page text alignment issue #2469
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently while extracting a modern page as well as provisioning a modern page, the text alignment was not correctly set. See issue pnp#2465
|
Nice catch @gautamdsheth . Given this impacts the existing templates (eg all our templates in the provisioning service) we need to coordinate patching the provisioning service and the templates aligned with processing this PR. I'll not merge this one for the November release due to above reasons, but we'll process it asap in the course of next week. |
|
Is it clear in which release this problem will be fixed? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
Currently while extracting a modern page as well as provisioning a modern page, the text alignment was not correctly set as well as extracted. See issue #2465 . This PR fixes the issue by using the correct enum.