Multi speed fan #115
Merged
Multi speed fan #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not yet added a test for the new curves. Please don't merge until we check-in on Fri. |
lymereJ
reviewed
Sep 19, 2024
added 2 commits
September 26, 2024 14:39
|
@lymereJ not sure why still have conflicting files; I already tried to merge back from the develop branch and solve conflicts. But, I have fixed the problems you brought up last time and created a new test case for multi speed fan with the default curve. |
|
I don't think the test failures are due to something you've done. I'll push some changes to try to resolve it. |
lymereJ
reviewed
Oct 11, 2024
added 2 commits
October 14, 2024 10:21
|
@lymereJ I fixed the two minor points you pointed out last week. If you feel it's correct, can you click "merge pull request"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added multi speed fan using curves