feat: raw mode preserve original formats#49
Open
alexandretrotel wants to merge 9 commits intopmxt-dev:mainfrom
Open
feat: raw mode preserve original formats#49alexandretrotel wants to merge 9 commits intopmxt-dev:mainfrom
alexandretrotel wants to merge 9 commits intopmxt-dev:mainfrom
Conversation
raw/normalized modes
Contributor
|
I'll review asap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal if this PR is to add a
rawmode that allows to skip price normalization if user wants the raw data from the original exchange.For this, I've made the following changes.
Changes
moderequest option support (normalizedby default, andrawas an opt-in).Refactor
I've also refactored some code as noted above. Here are the main changes. Of course, not everything here is really needed specifically for this issue but helps making the codebase better over the long term.
Any, explicit datetime handling, etc).Test
I've updated tests too but I need API keys for proper testing, I guess the CI will ensure proper testing and I might fix some code if it doesn't pass.