-
Notifications
You must be signed in to change notification settings - Fork 495
Add Option to Log Prestige Gains #1518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The game now logs gains of basic resources after resetting. A new message category, "Prestige Gains," has been added to allow players to view only the prestige-related messages. As with Achievement messages, the new Prestige messages are not cleared after resetting, allowing players to view messages from previous resets. These messages are displayed in the same color as messages for loot gained in battle and rewards from the Easter and Halloween events (light green). A new function `logPrestigeGains(reset)` was added along with calls in each reset specific function. I had to add several new strings to strings.json, mainly for formatting the list of gained resources along with two containing singular forms of "Servants" and "Skilled Servants". Example messages: - Gained 130 Plasmids from Mutual Assured Destruction. - Gained 2225 Plasmids, 139 Phage, and 2.4 Harmony Crystals from Ascension. - Gained 1 Plasmid and 64 Supercoiled Plasmids from Apotheosis. - Gained 2056 Anti-Plasmids, 167 Phage, 3 Servants, and 1 Skilled Servant from Matrix.
As the number of gained servants and skilled servants are not included in the data from calcPrestige, separate calculations had to be added using code based off of the block updating the counts of servants at the start of a game in main.js. New strings for singular "Servant" and "Skilled Servant" were also added. Also refactored code to figure out the correct name for the current resource in the report to be a switch statement.
Adds a new control to the settings tab to control weather prestige summaries should be logged. The new prestige messages will only be sent if the option is enabled (by default its off). Put it by "disable special events" as that was the only option that seemed vaguely related to messages.
|
Format in Chinese is different e.g. |
Rephrased strings to have the reset type be at the start of the sentence. For example: `Ascension earned you 2225 Plasmids, 139 Phage, and 2.4 Harmony Crystals.` I just left `prestige_report_list_end` to hold a '.'. Separated the string for " and" into two, one with the comma and one without. It is hoped that this will make it easier for languages which never have a comma (or other separator) before the and. Also made some spacing at the top of code blocks slightly more consistant.
|
I have tweaked the strings and code to try to make them easier to translate. Rephrased strings so that the reset type appears at the start of the sentence. Now, an English message might read, Also separated the string for " and" into two: one version with the comma and one without. This change is meant to make translation easier for languages that never use a comma (or other separator) before there equivlent of "and." @LoveBodhi, does this format work better for a Chinese translation? |
This time, now fine. |
Added the ability to log gains of basic prestige resources after resetting. Specifically, the gains of Plasmids, Anti-Plasmids, Dark Energy, Harmony Crystals, Artifacts, Supercoiled Plasmids, Servants, and Skilled Servants are listed. A new message category, "Prestige Gains," has been added to allow players to view only the prestige-related messages. As with Achievement messages, the new Prestige messages are not cleared after resetting, allowing players to view messages from previous resets. These messages are displayed in the same green color used for loot-related messages in battle and for rewards from the Easter and Halloween events. A new option has also been added to the settings tab to control whether these messages should be printed (this currently defaults to off).
Closes #660
A new function,
logPrestigeGains(reset, gains), was added along with calls in each reset-specific function. Most of the data comes fromcalcPrestigeGains(). The calculations for Servant and Skilled Servant gains use logic based on the code that determines the number of servants at the start of the game inmain.js, which also includes gains from Path Finder and Overlord.I had to add several new strings to
strings.json: five for formatting the list of gained resources, two for the singular forms of "Servants" and "Skilled Servants," and a further two for the new setting. The new strings were not added to any of the non-English string files in this PR.Note that any saves containing any of the new messages will break past game versions that do not implement the "Prestige" message category. Deleting the data in "lastMsg.prestige" from the save makes it compatible again, or just clicking the "Clear All" messages button. Loading games from previous versions works fine, so I don't think this will affect average players.
Example messages (using current phrasing):
Attached screenshots of the above Ascension message in the log and one of the settings tab with the new option.