Fix priority between sequencing and building queue #1509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves an issue introduced by pmotschmann#1468. Although priority inversion between the research queue and gene assembly remains resolved, a new priority inversion issue between the building queue and gene assembly was created. This commit also fixes some logic associated with "No Queue Order" ARPA.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an issue introduced by #1468. Although priority inversion between the research queue and gene assembly remains resolved, a new priority inversion issue between the building queue and gene assembly was created. Both regular buildings and ARPA projects are now resolved. I tested the patch.
This commit also fixes some logic associated with "No Queue Order" ARPA. The issue has existed for some years. Example bug report: https://discord.com/channels/586926974585274373/1351636478966366218
Some very minor performance enhancements for specific situations are also included.