A few Heading Adjustments for Screen Readers #1461
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AERobert
force-pushed
the
misc_heading_fixes
branch
from
1d0471f to
fd09ffb
Compare
Every Civilization sub tab except for City had a screen reader only h2 element at the top. This commit adds one for consistency in the drawCity() function.
* Adds a screen reader only h2 element to the top of the government tab. * Use aria-level to make the "Garrison" and "Foreign Powers " headings to appear as h3s. (only on the government tab) * Use aria to have the names of each foreign nation appear as h4s.
Most wiki pages have at least one set of headings allowing quick navigation between the main items on the page. As far as I can tell, the perks page is the only exception. This change uses aria to make the names of each perk appear as h2s.
All the "Cost" and "Cost Creep" headings for each structure and ARPA project were H2 headings, the same as the heading with each structure's name, so it could take up to three times longer to navigate one of these wiki pages using a screen reader. This change uses the aria-level attribute to make these headings appear as H3 headings to screen readers.
Update to code of 1.4.9.
AERobert
force-pushed
the
misc_heading_fixes
branch
from
fd09ffb to
ff0dc98
Compare
Contributor
Author
|
Merged with current Master branch (sorry for force pushing). Also updated the new city heading to use the current city tab label so it changes as the population increases. |
Edit the code for the new city tab heading again so that the name correctly updates with the growing population reactively. The last commit made it updatable, but it would only do so when the tab reloaded. Code wise, just added a call to vBind to the heading element and the tabLabel function.
Contributor
Author
|
Fixed the city heading to be actually reactive using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All changes either use
ariato have already existent elements appear as different headings to screen readers, or changeis-sr-onlyheadings only visible to screen readers, so nothing should change visually.