-
Couldn't load subscription status.
- Fork 308
coll: Collective Selection Summary Printout #7509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Here is an example of the output. |
|
Maybe a separate CVAR? It is too much output to fit into debug summary. |
|
Commenting to record in-person discussion; It would be great to have value ranges in the per-algorithm summary to see when each rule actually applies |
039e5d8 to
bb91990
Compare
|
test: mpich/ch4/ofi |
|
test: mpich/ch4/ofi |
bc08abc to
28f6b0c
Compare
|
test: mpich/ch4/ofi |
|
test:mpich/ch4/ofi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add commit messages
554aefb to
bc7abb8
Compare
|
From offline discussion, I need to split the optimization changes to a separate PR and only keep the print out one here. |
|
PR updates with only the changes to print of the collective selection. |
Creating CSEL constants array for the string name of collective and comm hierarchy. These string values will be used during parsing of the JSON file, and printing of the CSEL tree node. Separating the implementation details CSEL tree printing function for the ease of maintenance.
Consolidate the POSIX coll algorithm enum definition under MPII. The JSON parsing no longer need separate functions for them.
Consolidate the CH4 coll algorithm enum definition under MPII. The JSON parsing no longer need separate functions for them.
Consolidate the OFI coll algorithm enum definition under MPII. The JSON parsing no longer need separate functions for them.
MPIR_CVAR_COLLECTIVE_SELECTION_REPORT controls how MPICH show the collective selection logic during init. It is turned off by default. The user can choose to print the CSEL in tree format or summary format (later commit).
Pull Request Description
This is the first PR for the collective selection refactoring. This PR focus on providing better way to print the tree and summary of the loaded collective selection logic.
This PR merges the collective algorithm enums for MPIR, CH4, POSIX and OFI to once place. This allows us to print algorithm names using the string constants added in this PR. This change enables us to use the existing tree printing function to output meaningful info about the loaded tree.
This PR creates a new function to print the collective selection summarization. This format organizes the conditions by individual algorithm (see examples in the next comment). Both tree and summary report format are controlled by a new CVAR
MPIR_CVAR_COLLECTIVE_SELECTION_REPORT={none, tree, summary, all}.Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.