Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zustand Docs] Add third party library zustand-async-slice #2730

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

mym0404
Copy link
Contributor

@mym0404 mym0404 commented Sep 10, 2024

Hello, I read contributing guide. However, the docs branch of website is missing and I can't find proper way.

So I created a PR in a simple way, and if this causes problems or results in the documentation not being properly updated, I would like to know what actions I should take.

Summary

Add zustand-async-slice package into zustand third party library listing.

Check List

  • pnpm run prettier for formatting code and docs

Hello, I read [contributing guide](https://github.com/pmndrs/zustand/blob/main/CONTRIBUTING.md). However, the main branch of `website` is missing and I can't find proper way.
Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 11:23am

Copy link

codesandbox-ci bot commented Sep 10, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi
Copy link
Member

dai-shi commented Sep 10, 2024

contributing guide seems outdated... cc @dbritto-dev ?

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reorder.

docs/integrations/third-party-libraries.md Outdated Show resolved Hide resolved
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dai-shi dai-shi merged commit fec9135 into pmndrs:main Sep 11, 2024
26 checks passed
@mym0404 mym0404 deleted the patch-1 branch September 11, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants