Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove recipes #2085

Merged
merged 7 commits into from
Sep 28, 2023
Merged

Remove recipes #2085

merged 7 commits into from
Sep 28, 2023

Conversation

dbritto-dev
Copy link
Collaborator

Related Issues or Discussions

Fixes #1033 (reply in thread)

Summary

Remove recipes

Check List

  • yarn run prettier for formatting code and docs

@vercel
Copy link

vercel bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 3:14pm

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 27, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 42dde45:

Sandbox Source
React Configuration
React TypeScript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration
@pavlobu/zustand demo Configuration

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, do we not have anything to leave in docs?

readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
@dbritto-dev
Copy link
Collaborator Author

So, do we not have anything to leave in docs?

No, we don't. Actually everything on recipes are duplicated on readme, typescript and call outside of react context

readme.md Outdated Show resolved Hide resolved
dbritto-dev and others added 2 commits September 27, 2023 09:45
Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>
Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>
@dai-shi
Copy link
Member

dai-shi commented Sep 27, 2023

zustand/readme.md

Lines 168 to 170 in 8e8156f

// ...
},
}))

We actually want to change this ☝️ to just ... for consistency.

@dbritto-dev
Copy link
Collaborator Author

zustand/readme.md

Lines 168 to 170 in 8e8156f

// ...
},
}))

We actually want to change this ☝️ to just ... for consistency.

Done

readme.md Outdated Show resolved Hide resolved
Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>
@dbritto-dev
Copy link
Collaborator Author

@dai-shi all yours

@dbritto-dev
Copy link
Collaborator Author

@dai-shi you have to merge it

@dai-shi dai-shi merged commit 60d7116 into pmndrs:main Sep 28, 2023
@dbritto-dev dbritto-dev deleted the remove-recipes branch September 28, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants