fix(docs): comparison #1284
Merged
fix(docs): comparison #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 143c072:
|
dai-shi
approved these changes
Sep 10, 2022
|
@chrisk-7777 @CallumCrichton @Exalted100 what you think folks? |
ghost
reviewed
Sep 15, 2022
ghost
suggested changes
Sep 15, 2022
|
@dai-shi done |
|
@chrisk-7777 @bjornstar would you mind reviewing this PR? |
Exalted100
approved these changes
Sep 20, 2022
|
@dbritto-dev just checked and it looks fine to me. Although I would personally prefer active statements like "we recommend..." over passive ones like "it is recommended..." However, it's fine either way. |
bjornstar
reviewed
Sep 20, 2022
Co-authored-by: Bjorn Stromberg <bjorn@bjornstar.com>
|
@bjornstar @Exalted100 done |
dbritto-dev
requested review from
bjornstar and
dai-shi
and removed request for
bjornstar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes #1008
Summary
Adding some improvements to comparison docs
Check List
yarn run prettierfor formatting code and docs