Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types)(middleware/devtools): fix action type in devtools's setState #1183

Merged
merged 12 commits into from
Aug 18, 2022
Merged

fix(types)(middleware/devtools): fix action type in devtools's setState #1183

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ea70466
added payload to setState() in devtools middleware
lucasrabiec Aug 10, 2022
9bbf125
adjusted tests
lucasrabiec Aug 11, 2022
bcc5e0b
changed payload to any property name
lucasrabiec Aug 12, 2022
8e79ade
adjusted docs
lucasrabiec Aug 12, 2022
3bb1fc8
prettier readme.md
lucasrabiec Aug 12, 2022
ce2a715
adjusted for extends
lucasrabiec Aug 12, 2022
50ce327
adjusted immer's setState
lucasrabiec Aug 14, 2022
a6b8c35
Revert "adjusted immer's setState"
lucasrabiec Aug 14, 2022
f8fe591
changed order of immer and devtools in tests
lucasrabiec Aug 14, 2022
f2f4ef8
added test for action with payload type in immer/devtools
lucasrabiec Aug 15, 2022
ebbee73
removed unnecessary test
lucasrabiec Aug 15, 2022
ccb85bf
Update tests/middlewareTypes.test.tsx
dai-shi Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
adjusted tests
  • Loading branch information
@lucasrabiec
lucasrabiec committed Aug 11, 2022
commit 9bbf12536409dbb4a6ece3f62af99d59e49b4b6f
32 changes: 12 additions & 20 deletions tests/devtools.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,45 +78,37 @@ describe('If there is no extension installed...', () => {
expect(console.warn).not.toBeCalled()
})
})

describe('When state changes...', () => {
it("sends { type: 'testSetStateName' } as the action with current state", () => {
const { setState } = createTestState()
setState({ count: 10 }, false, 'testSetStateName')
it("sends { type: testSetStateName || 'anonymous`, ...rest } as the action with current state", () => {
lucasrabiec marked this conversation as resolved.
Show resolved Hide resolved
const api = create(
devtools(() => ({ count: 0, foo: 'bar' }), {
name: 'testOptionsName',
enabled: true,
})
)

api.setState({ count: 10 }, false, 'testSetStateName')
expect(extension.send).toHaveBeenLastCalledWith(
{ type: 'testSetStateName' },
{ count: 10, foo: 'bar' }
)
})

it("sends { type: 'testSetStateName', payload: 15 } as the action with current state", () => {
const { setState } = createTestState()
setState({ count: 15 }, false, {
api.setState({ count: 15 }, false, {
type: 'testSetStateName',
payload: 15,
})
expect(extension.send).toHaveBeenLastCalledWith(
{ type: 'testSetStateName', payload: 15 },
{ count: 15, foo: 'bar' }
)
})

it("sends { type: 'anonymous' } as the action with current state", () => {
const { setState } = createTestState()
setState({ count: 5, foo: 'baz' }, true)
api.setState({ count: 5, foo: 'baz' }, true)
expect(extension.send).toHaveBeenLastCalledWith(
{ type: 'anonymous' },
{ count: 5, foo: 'baz' }
)
})

function createTestState() {
return create(
devtools(() => ({ count: 0, foo: 'bar' }), {
name: 'testOptionsName',
enabled: true,
})
)
}
})

describe('when it receives an message of type...', () => {
Expand Down