Skip to content

feat: Add eslint file import organization rule #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 16, 2025
Merged

feat: Add eslint file import organization rule #434

merged 7 commits into from
May 16, 2025

Conversation

taeuscherpferd
Copy link
Contributor

@taeuscherpferd taeuscherpferd commented May 15, 2025 •
edited
Loading

This is the follow up pull request to update eslint to organize the imports at the top of the file. Was mentioned during the discussion of my last pull request.

Changes

  • Added a new import rules to the eslintrc
  • Added fix:eslint and check:eslint steps to every package.json in the repo
  • Added a vscode config file to disable vscode's auto import sorting rules, and apply the eslintrc version on save
  • Ran pnpm -r fix:eslint to organize and cleanup all of the imports in the repo

Kailean O'Keefe and others added 7 commits May 13, 2025 08:25
bug:
b9c0188 
- Fixed a script formatting bug that prevents the eslint commands from being run on windows
- Added an unused import plugin to eslint
- Updated the eslint script to automatically cleanup and organize imports on fix.
Merge branch 'updating-the-hook-documentation' into Add-ESLint-File-I…
47414dc 
…mport-Organization-Rule
@taeuscherpferd
chore: Added eslint fix scripts to all package.json files in the project
e4ba348
@taeuscherpferd
chore: undo update eslint and plugins. Added vscode config
80c6d74
@taeuscherpferd
chore: Removed a reference to a previous attempted plugin
8e6eae4
@taeuscherpferd
bug: Not all projects include a src directory. Modified package.json …
676b730 
…in those projects to respect that
@taeuscherpferd
chore: Applied all of the new eslint rules
181b900
@taeuscherpferd taeuscherpferd changed the title feat: Add es lint file import organization rule feat: Add eslint file import organization rule May 15, 2025
@bbohlender bbohlender merged commit 8718554 into pmndrs:main May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taeuscherpferd @bbohlender