Implement AfterImageEffect #665

Activity

1. TamagawaJousui

   added

   feature requestNew feature requestNew feature request

   on Oct 26, 2024
2. vanruesc commented on Oct 31, 2024

   

   vanruesc

   on Oct 31, 2024

   Member

   More actions

   There haven't been any plans to add AfterImageEffect yet, but I think it's fine to add it.

   Feel free to prepare a PR if you'd like to work on it, but please note that this should be implemented as an Effect instead of a Pass. It should also be implemented for v7 because v6 is in maintenance mode at this point.

   I'd recommend implementing it as a simple Effect that uses an internal pass to generate the after-image texture. The effect can just use the existing texture.frag shader as its main fragmentShader to auto blend the map with the input image. You can check TextureEffect for reference (only need to set the map uniform).

   The internal pass should probably be called FeedbackPass because it might be useful for other effects in the future. Likewise, the feedback copy shader used by that pass should be called FeedbackMaterial.

   For the demo, you can copy tone-mapping and add a simple rotating mesh.

   👍React with 👍1Reacted by 玉川城翠
3. vanruesc

   changed the title [-]Is afterimagepass nice to have?[/-] [+]Implement AfterImageEffect[/+] on Nov 2, 2024
4. vanruesc

   added this to the v7 milestone on Nov 2, 2024
5. vanruesc

   removed

   feature requestNew feature requestNew feature request

   on Feb 17, 2025