Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gizmo up vector #496

Merged
merged 4 commits into from
Aug 4, 2021
Merged

Gizmo up vector #496

merged 4 commits into from
Aug 4, 2021

Conversation

w3dot0
Copy link
Contributor

@w3dot0 w3dot0 commented Jul 27, 2021

Why

Fixes #465

What

  • update camera up vector during animation
  • replace onPointerDown with onClick to fix event propagation issues

Made some other improvements that help with testing:

  • collapse ViewCube and ViewCube storybook pages
  • add control selection (Orbit/Trackball) in storybook page
  • add gizmo-specific knobs to storybook page

Checklist

  • Documentation updated
  • Storybook entry added
  • Ready to be merged

@vercel
Copy link

vercel bot commented Jul 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/drei/CELNPbtoA2HpwasSz82b2cg4dJxF
✅ Preview: https://drei-git-fork-w3dot0-gizmoupvector-pmndrs.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 27, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a7db1da:

Sandbox Source
winter-cdn-19e8n Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration
Trackball gizmo Issue #465

@drcmda
Copy link
Member

drcmda commented Aug 4, 2021

awesome @w3dot0 ! let's merge it ...

btw, i have another question, could the core of this control be made self-sufficient? so that users get to control the camera programmatically no matter if its ortho/perp or controlled, something like

const api = useControls({ damping: true, ... ??? })

api.zoom(500)
api.rotateTheta(Math.PI / 2)
api.pan(x, y)
...

@drcmda drcmda merged commit a2befcd into pmndrs:master Aug 4, 2021
@github-actions
Copy link

🎉 This PR is included in version 7.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gizmo is broken when using trackback controls
2 participants