fix(TrackballControls): invalidate on user input with demand frameloops#2746
Open
DevTomUK wants to merge 1 commit into
Open
fix(TrackballControls): invalidate on user input with demand frameloops#2746DevTomUK wants to merge 1 commit into
DevTomUK wants to merge 1 commit into
Conversation
|
@DevTomUK is attempting to deploy a commit to the Poimandres Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2745 (same problem as #1588 and #708)
TrackballControls is dead on arrival with
frameloop="demand". The three-stdlib impl only applies pointer input insideupdate(), which drei runs inuseFrame— but in demand mode no frame ever gets requested, soupdate()never runs and nothing you do produces a render. OrbitControls doesn't have this issue because its impl updates straight from the pointer handlers.Fix: invalidate on the controls'
startevent, and on pointermove/touchmove while interacting. Wheel is covered too since it firesstartper event.Tested in a demand-frameloop sandbox: before, dragging renders nothing and the camera never moves; after, drag and wheel both work and damping settles on its own.