Skip to content

fix: lazy load hls events for video textures#2732

Open
raashish1601 wants to merge 1 commit into
pmndrs:masterfrom
raashish1601:codex/lazy-hls-events
Open

fix: lazy load hls events for video textures#2732
raashish1601 wants to merge 1 commit into
pmndrs:masterfrom
raashish1601:codex/lazy-hls-events

Conversation

@raashish1601

@raashish1601 raashish1601 commented May 14, 2026

Copy link
Copy Markdown

Summary

VideoTexture lazy-loads hls.js for HLS sources, but importing Events from hls.js at module scope still creates a runtime dependency for every consumer. This keeps both the constructor and event constants behind the dynamic import so the HLS package is only loaded when an .m3u8 source is used.

Validation

  • corepack yarn typecheck
  • corepack yarn eslint src/core/VideoTexture.tsx
  • corepack yarn prettier --check src/core/VideoTexture.tsx
  • corepack yarn build (passes with existing Rollup warnings about unused ThreeElements imports and stale Browserslist data)
  • git diff --check origin/master...HEAD

@vercel

vercel Bot commented May 14, 2026

Copy link
Copy Markdown

@raashish1601 is attempting to deploy a commit to the Poimandres Team on Vercel.

A member of the Team first needs to authorize it.

@codesandbox-ci

codesandbox-ci Bot commented May 14, 2026

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@raashish1601 raashish1601 force-pushed the codex/lazy-hls-events branch from 74186fd to 53c1cfa Compare May 15, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant