Skip to content

Fix GizmoHelper ViewCube radius to use focus point#2729

Open
raashish1601 wants to merge 1 commit into
pmndrs:masterfrom
raashish1601:codex/2374-gizmohelper-non-origin-target-radius
Open

Fix GizmoHelper ViewCube radius to use focus point#2729
raashish1601 wants to merge 1 commit into
pmndrs:masterfrom
raashish1601:codex/2374-gizmohelper-non-origin-target-radius

Conversation

@raashish1601

Copy link
Copy Markdown

Summary

  • Use the active focusPoint.current when computing the ViewCube camera radius.
  • This keeps camera distance relative to the current orbit target instead of world origin when the target is offset.

Fixes #2374.

Validation

  • npm exec -- eslint src/core/GizmoHelper.tsx
  • npm exec -- tsc --noEmit --emitDeclarationOnly false --strict --jsx react (fails on existing unrelated errors in src/core/Splat.tsx and src/web/Select.tsx)

@vercel

vercel Bot commented May 11, 2026

Copy link
Copy Markdown

@raashish1601 is attempting to deploy a commit to the Poimandres Team on Vercel.

A member of the Team first needs to authorize it.

@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GizmoHelper: ViewCube camera drifts when target is not at origin

1 participant