Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facemesh v2 #1437

Merged
merged 4 commits into from
May 10, 2023
Merged

Facemesh v2 #1437

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf89b6e
feat(Facemesh): it now looks in the same direction as the face
abernier May 9, 2023
2a2497d
fix: avoiding creating disposable objects imperatively
abernier May 9, 2023
9e85de5
feat: origin landmark prop
abernier May 10, 2023
7531949
fix: initial useState value as function initializer
abernier May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: initial useState value as function initializer
  • Loading branch information
@abernier
abernier committed May 10, 2023
commit 753194938b81dae5d2bceae0187347325167827a
16 changes: 8 additions & 8 deletions src/core/Facemesh.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,21 +48,21 @@ export const Facemesh = React.forwardRef<FacemeshApi, FacemeshProps>(
const outerRef = React.useRef<THREE.Group>(null)
const meshRef = React.useRef<THREE.Mesh>(null)

const [sightDir] = React.useState(new THREE.Vector3())
const [sightDirQuaternion] = React.useState(new THREE.Quaternion())
const [sightDir] = React.useState(() => new THREE.Vector3())
const [sightDirQuaternion] = React.useState(() => new THREE.Quaternion())

const { invalidate } = useThree()

React.useEffect(() => {
meshRef.current?.geometry.setIndex(FacemeshDatas.TRIANGULATION)
}, [])

const [a] = React.useState(new THREE.Vector3())
const [b] = React.useState(new THREE.Vector3())
const [c] = React.useState(new THREE.Vector3())
const [ab] = React.useState(new THREE.Vector3())
const [ac] = React.useState(new THREE.Vector3())
const [bboxSize] = React.useState(new THREE.Vector3())
const [a] = React.useState(() => new THREE.Vector3())
const [b] = React.useState(() => new THREE.Vector3())
const [c] = React.useState(() => new THREE.Vector3())
const [ab] = React.useState(() => new THREE.Vector3())
const [ac] = React.useState(() => new THREE.Vector3())
const [bboxSize] = React.useState(() => new THREE.Vector3())
React.useEffect(() => {
const geometry = meshRef.current?.geometry
if (!geometry) return
Expand Down