Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GizmoHelper axis head rotation snaps the camera to an incorrect alignment with TrackballControls #962

Open
discosultan opened this issue Jun 30, 2022 · 3 comments · Fixed by #973
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@discosultan
Copy link
Contributor

  • three version: 0.142.0
  • @react-three/fiber version: 8.0.27
  • @react-three/drei version: 9.14.3
  • node version: 18.3.0
  • npm (or yarn) version: 8.11.0

Problem description:

When using GizmoHelper with TrackballControls, if the camera is moved from its' default location, using the GizmoHelper axis head to automatically rotate the camera ends up misaligning the camera. See the gif below:
gizmohelper

The issue can be reproduced in the storybook: https://drei.pmnd.rs/?path=/story/gizmos-gizmohelper--gizmo-helper-story&args=controls:TrackballControls

Steps:

  1. Rotate the camera around the object arbitrarily holding mouse left button
  2. Click on one of the GizmoHelper axis heads to align camera to a specific direction

I was not able to reproduce the issue with OrbitControls.

@discosultan discosultan added the bug Something isn't working label Jun 30, 2022
@FarazzShaikh FarazzShaikh self-assigned this Jul 8, 2022
FarazzShaikh added a commit to FarazzShaikh/drei that referenced this issue Jul 8, 2022
@FarazzShaikh FarazzShaikh mentioned this issue Jul 8, 2022
3 tasks
@github-actions
Copy link

🎉 This issue has been resolved in version 9.17.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@FarazzShaikh
Copy link
Member

Reopening as there still seems to be some inconsistant jank when snapping from -x to -y

@FarazzShaikh FarazzShaikh reopened this Jul 10, 2022
@FarazzShaikh FarazzShaikh removed their assignment Jul 10, 2022
@FarazzShaikh FarazzShaikh added help wanted Extra attention is needed and removed released labels Jul 10, 2022
@FarazzShaikh
Copy link
Member

Might be related with #522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants