Skip to content

Updated for latest master #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 17, 2018
Merged

Updated for latest master #1

merged 4 commits into from
Jun 17, 2018

Conversation

dktapps
Copy link
Member

@dktapps dktapps commented Jun 10, 2018

No description provided.

SOF3
SOF3 previously requested changes Jun 11, 2018

class BroadcastPluginTask extends PluginTask{
class BroadcastPluginTask extends Task{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename the class too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why it was called that in the first place to be honest, it had no association with the actual plugin in terms of top level code.

@dktapps dktapps merged commit d376927 into master Jun 17, 2018
@dktapps dktapps deleted the dev branch June 17, 2018 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants