Skip to content

Commit

Permalink
validate.sh: migrate 'setup.py develop' -> 'pip install -e'
Browse files Browse the repository at this point in the history
This fixed deprecation warnings in console:
/home/buildbot/.venv/lib/python3.10/site-packages/setuptools/__init__.py:80: _DeprecatedInstaller: setuptools.installer and fetch_build_eggs are deprecated.
!!

        ********************************************************************************
        Requirements should be satisfied by a PEP 517 installer.
        If you are using pip, you can try `pip install --use-pep517`.
        ********************************************************************************

!!
  dist.fetch_build_eggs(dist.setup_requires)
/home/buildbot/.venv/lib/python3.10/site-packages/setuptools/command/develop.py:39: EasyInstallDeprecationWarning: easy_install command is deprecated.
!!

        ********************************************************************************
        Please avoid running ``setup.py`` and ``easy_install``.
        Instead, use pypa/build, pypa/installer or other
        standards-based tools.

        See pypa/setuptools#917 for details.
        ********************************************************************************

!!
  easy_install.initialize_options(self)
/home/buildbot/.venv/lib/python3.10/site-packages/setuptools/_distutils/cmd.py:66: SetuptoolsDeprecationWarning: setup.py install is deprecated.
!!

        ********************************************************************************
        Please avoid running ``setup.py`` directly.
        Instead, use pypa/build, pypa/installer or other
        standards-based tools.

        See https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html for details.
        ********************************************************************************
  • Loading branch information
pmisik committed Jan 8, 2024
1 parent d5388d0 commit 8e3648b
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions common/validate.sh
Original file line number Diff line number Diff line change
Expand Up @@ -145,11 +145,11 @@ git log "$REVRANGE" --pretty=oneline || exit 1
if ! $quick && ! $no_js; then
for module in www/react-base www/react-console_view www/react-grid_view www/react-waterfall_view www/badges;
do
status "running 'setup.py develop' for $module"
if ! (cd $module; python setup.py develop >/dev/null ); then
warning "$module/setup.py failed; retrying with cleared build/ dist/"
status "running 'pip install -e' for $module"
if ! (cd $module; pip install -e . >/dev/null ); then
warning "pip install -e for $module failed; retrying with cleared build/ dist/"
rm -rf "$module/build" "$module/dist"
(cd $module; python setup.py develop >/dev/null ) || not_ok "$module/setup.py failed"
(cd $module; pip install -e . >/dev/null ) || not_ok "$module/setup.py failed"
fi
done
else
Expand Down

0 comments on commit 8e3648b

Please sign in to comment.